Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/subscriber notification #36323

Merged
merged 15 commits into from
Mar 14, 2024
Merged

Feature/subscriber notification #36323

merged 15 commits into from
Mar 14, 2024

Conversation

markoskandylis
Copy link
Contributor

@markoskandylis markoskandylis commented Mar 12, 2024 •
edited
Loading

Description

Creates Subscriber Notification Resource

Relations

Closes #36325

References

https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateSubscriberNotification.html#securitylake-CreateSubscriberNotification-response-subscriberEndpoint

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccSecurityLake_serial/SubscriberNotification' PKG=securitylake  ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securitylake/... -v -count 1 -parallel 1  -run=TestAccSecurityLake_serial/SubscriberNotification -timeout 360m
=== RUN   TestAccSecurityLake_serial
=== PAUSE TestAccSecurityLake_serial
=== CONT  TestAccSecurityLake_serial
=== RUN   TestAccSecurityLake_serial/SubscriberNotification
=== RUN   TestAccSecurityLake_serial/SubscriberNotification/basic
=== PAUSE TestAccSecurityLake_serial/SubscriberNotification/basic
=== RUN   TestAccSecurityLake_serial/SubscriberNotification/https
=== PAUSE TestAccSecurityLake_serial/SubscriberNotification/https
=== RUN   TestAccSecurityLake_serial/SubscriberNotification/disappears
=== RUN   TestAccSecurityLake_serial/SubscriberNotification/update
=== CONT  TestAccSecurityLake_serial/SubscriberNotification/basic
=== CONT  TestAccSecurityLake_serial/SubscriberNotification/https
--- PASS: TestAccSecurityLake_serial (327.85s)
    --- PASS: TestAccSecurityLake_serial/SubscriberNotification (202.05s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/disappears (93.21s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/update (108.83s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/basic (61.22s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/https (64.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securitylake	332.548s

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/securitylake Issues and PRs that pertain to the securitylake service. and removed size/XL Managed by automation to categorize the size of a PR. labels Mar 12, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Mar 12, 2024
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Mar 12, 2024
@markoskandylis markoskandylis marked this pull request as ready for review March 12, 2024 19:15
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 13, 2024
@ewbankkit ewbankkit self-assigned this Mar 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 14, 2024
ewbankkit
ewbankkit approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSecurityLake_serial/SubscriberNotification' PKG=securitylake
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/securitylake/... -v -count 1 -parallel 20  -run=TestAccSecurityLake_serial/SubscriberNotification -timeout 360m
=== RUN   TestAccSecurityLake_serial
=== PAUSE TestAccSecurityLake_serial
=== CONT  TestAccSecurityLake_serial
=== RUN   TestAccSecurityLake_serial/SubscriberNotification
=== RUN   TestAccSecurityLake_serial/SubscriberNotification/basic
=== RUN   TestAccSecurityLake_serial/SubscriberNotification/https
=== RUN   TestAccSecurityLake_serial/SubscriberNotification/disappears
=== RUN   TestAccSecurityLake_serial/SubscriberNotification/update
--- PASS: TestAccSecurityLake_serial (325.45s)
    --- PASS: TestAccSecurityLake_serial/SubscriberNotification (325.45s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/basic (72.49s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/https (73.14s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/disappears (61.06s)
        --- PASS: TestAccSecurityLake_serial/SubscriberNotification/update (118.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securitylake	332.644s

@ewbankkit
Copy link
Contributor

@markoskandylis Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9648935 into hashicorp:main Mar 14, 2024
35 checks passed
@github-actions github-actions bot added this to the v5.41.0 milestone Mar 14, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 14, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/securitylake Issues and PRs that pertain to the securitylake service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.41.0
Development

Successfully merging this pull request may close these issues.

[New]: Resource for Security Lake Subscriber Notification
3 participants
@markoskandylis @ewbankkit @justinretzolk